ERR: Fix GH13139: better error message on invalid pd.eval and df.query input #14473
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tserafim
changed the title
Current coverage is 85.26% (diff: 100%)@@ master #14473 diff @@
==========================================
Files 140 140
Lines 50640 50641 +1
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 43175 43178 +3
+ Misses 7465 7463 -2
Partials 0 0
|
jreback
reviewed
Oct 24, 2016
| @@ -57,3 +57,4 @@ Bug Fixes | |||
|
|
|||
| - Bug in ``pd.pivot_table`` may raise ``TypeError`` or ``ValueError`` when ``index`` or ``columns`` | |||
| is not scalar and ``values`` is not specified (:issue:`14380`) | |||
| - pd.eval('') and df.query('') now show better error message and raise ``ValueError`` (:issue: `13139`) | |||
There was a problem hiding this comment.
more like
correctly raise ValueError on empty input to pd.eval() and df.query(). This
jreback
reviewed
Oct 24, 2016
| @@ -1891,6 +1891,17 @@ def test_bad_resolver_raises(): | |||
| yield check_bad_resolver_raises, engine, parser | |||
|
|
|||
|
|
|||
| def check_empty_string_raises(engine, parser): | |||
| tm.skip_if_no_ne(engine) | |||
There was a problem hiding this comment.
add the issue refernce in a comment
|
just a doc-comment. pls push ; ping when green. |
|
thanks! |
jorisvandenbossche
pushed a commit
to jorisvandenbossche/pandas
that referenced
this pull request
Nov 2, 2016
… invalid pd.eval and df.query input closes pandas-dev#13139 Added test case to check for invalid input(empy string) on pd.eval('') and df.query(''). Used existing helper function(_check_expression) Author: Thiago Serafim <[email protected]> Closes pandas-dev#14473 from tserafim/issue#13139 and squashes the following commits: 77483dd [Thiago Serafim] ERR: correctly raise ValueError on empty input to pd.eval() and df.query() (pandas-dev#13139) 9a5c55f [Thiago Serafim] Fix GH13139: better error message on invalid pd.eval and df.query input (cherry picked from commit 1308884)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master | flake8 --diffAdded test case to check for invalid input(empy string) on pd.eval('') and df.query('').
Used existing helper function(_check_expression)